Skip to content

Conversation

@lucanicoletti
Copy link
Contributor

Fixes #531

Update the Circle function to use Color.Black as default, and a radius of 10

@google-cla
Copy link

google-cla bot commented Nov 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kikoso
Copy link
Collaborator

kikoso commented Nov 30, 2024

@lucanicoletti , could this be changed to a fix? This is not really a full feature, and it should trigger a patch release. We follow the semantic-release procedere.

@lucanicoletti lucanicoletti changed the title feat: update circle to be black and have a radius of 10 fix: update circle to be black and have a radius of 10 Nov 30, 2024
Copy link
Collaborator

@kikoso kikoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc/ @dkhawk

@lucanicoletti
Copy link
Contributor Author

The tests are failing for Maps API key not specified, which shouldn't be related to this change in the specific.

@kikoso
Copy link
Collaborator

kikoso commented Dec 2, 2024

@lucanicoletti , this is ok. Unfortunately the runner is executing on the Google Maps instance, and it does not have access to your local API Key. Tests are passing, though - you can verify it locally.

@dkhawk dkhawk merged commit 1fad9ef into googlemaps:main Dec 2, 2024
10 of 11 checks passed
googlemaps-bot pushed a commit that referenced this pull request Dec 2, 2024
# [6.3.0](v6.2.1...v6.3.0) (2024-12-02)

### Features

* update circle to be black and have a radius of 10 ([#656](#656)) ([1fad9ef](1fad9ef))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 6.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Radius required, use Black as colour in Circle

4 participants